Workers Auto Approve
[ traderOrderAsync ] add final checks and watch for error events
## Before you `start work`
Please read our contribution [guidelines](https://docs.marketprotocol.io/#contributing) and if there is a bounty involved please also see [here](https://docs.marketprotocol.io/#gitcoin-and-bounties)
If you have ongoing work from other bounties with us where funding has not been released, please do not pick up a new issue. We would like to involve as many contributors as possible and parallelize the work flow as much as possible.
Please make sure to comment in the issue here immediately after starting work so we know your plans for implementation and a timeline.
Please also note that in order for work to be accepted, all code must be accompanied by test cases as well.
### User Story
As a user I want to be able to see any ErrorEvent from the traderOrder function and make sure do as much validation before calling the transaction on chain to avoid wasted gas!
### Why Is this Needed?
*Summary*: provide a better UX and error reporting / debugging
### Definition of Done
- [ ] Add check for approval amounts of MKT We currently are checking that if there are fees, the maker and taker both have enough MKT in order to pay for those fees, but we do not check that they have approved sufficient qty (by calling `ERC20.approve()`) to be able to transfer those fees to the `feeRecipient`
- [ ] Add check to ensure the `MarketContract.isSettled` is false
- [ ] Add watch for the `ErrorEvent` from `MarketContract` and return any errors found during the call to traderOrderAsync (see the `OrderFilledEvent` watch for needed filters and reference)
- [ ] Create needed tests for all of these scenarios. (note, the ErrorEvent may be a bit challenging for an automated test to reproduce)
### Bounty Hunters - please give a proposed timeline for completion and brief plan for implementation in order for us to accept you to start work.
Setup your profile
Tell us a little about you:
No results found for
Type to search skills..
Required [[totalcharacter]] / 240
Are you currently looking for work?
[[ option.string ]]
Setup your profile
Our tools are based on the principles of earn (💰), learn (📖), and meet (💬).
Select the ones you are interested in. You can change it later in your settings.
I'm also an organization manager looking for a great community.
Enable your organization profile
Gitcoin products can help grow community around your brand. Create your tribe, events, and incentivize your community with bounties. Announce new and upcoming events using townsquare. Find top-quality hackers and fund them to work with you on a grant.
These are the organizations you own. If you don't see your organization here please be sure that information is public on your GitHub profile. Gitcoin will sync this information for you.
Select the products you are interested in:
Out of the box you will receive Tribes Lite for your organization. Please provide us with a contact email: